Mgmt Spring Cloud Deployment update #14423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenTanyi
requested review from
weidongxu-microsoft,
xseeseesee and
yungezz
as code owners
ChenTanyi
commented
Aug 25, 2020
Comment on lines
+125
to
+126
| public <T extends SpringAppDeployment.DefinitionStages.WithCreate<T>> SpringAppDeployments<T> deployments() { | ||
| return (SpringAppDeployments<T>) deployments; |
There was a problem hiding this comment.
If you have better solution for this unchecked warning, please comment. According to @weidongxu-microsoft, it seems the core library also use such way to suppress https://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/util/Collections.java#l4479
weidongxu-microsoft
approved these changes
Aug 26, 2020
|
Also please update the CHANGELOG (for the new version of appplatform). |
|
@weidongxu-microsoft Done |
xseeseesee
approved these changes
Aug 31, 2020
yungezz
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.